Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: deep copy the string when setting user variable from Chunk (#11041) #11043

Merged
merged 2 commits into from
Jul 3, 2019
Merged

expression: deep copy the string when setting user variable from Chunk (#11041) #11043

merged 2 commits into from
Jul 3, 2019

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Jul 3, 2019

cherry-pick #11041 to release-2.1

@zz-jason zz-jason added type/bugfix This PR fixes a bug. priority/release-blocker This issue blocks a release. Please solve it ASAP. component/expression type/2.1 cherry-pick labels Jul 3, 2019
@zz-jason
Copy link
Member Author

zz-jason commented Jul 3, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason requested review from XuHuaiyu and qw4990 July 3, 2019 03:01
@zz-jason
Copy link
Member Author

zz-jason commented Jul 3, 2019

/run-common-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

qw4990
qw4990 reviewed Jul 3, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 3, 2019
lzmhhh123
lzmhhh123 approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lzmhhh123 lzmhhh123 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 3, 2019
@zz-jason zz-jason merged commit 3affa57 into pingcap:release-2.1 Jul 3, 2019
@zz-jason zz-jason deleted the 2.1-deepcopy-for-setvar branch July 3, 2019 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zz-jason @qw4990 @lzmhhh123